DioxusLabs/taffy

Enforce values that must not be negative at a type level

Open

#207 opened on Jul 25, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (192 forks)github user discovery
good first issueusability

Repository metrics

Stars
 (3,189 stars)
PR merge metrics
 (PR metrics pending)

Description

What problem does this solve or what need does it fill?

Some values, such as flex_grow and flex_shrink, must not be negative, but are stored as a simple f32.

Documentation is a poor way to enforce this sort of constraint in Rust.

What solution would you like?

Use a non-negative float wrapper type. We can either hand-write this. or reuse an existing crate's work if something suitable exists.

Additional context

Noticed due to #206.

We should keep an eye out for other values that are similarly bounded as part of these changes.

Contributor guide

Research direction
Identify the current definition of flex grow and flex shrink fields, and create a non negative float wrapper type to replace f32.
Tech stack
rust
Domain
frontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60