Change Proposal: Add an accessible error state to NumberInput for other components to react to
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Quiet
- Tech stack
- typescript
- Domain
- accessibility, frontend
Research direction
Start by inspecting the NumberInput component and its current handling of invalid user-entered values. Define how an accessible error state should be exposed and how other components can react to it; the issue does not identify tests or a settled interface, so completion criteria require maintainer agreement.
Written by the indexing model from the issue text.
Description
What is being proposed?
As picked up by Atlas #143, the NumberInput currently shows user-entered invalid values, but does not commit them. As such, any form populated and used for further action may use outdated values.
Why is this needed?
Current behaviour of components which act on inputs from NumberInput is unpredictable for the user, as invalid values are shown as true to a user, but not committed. This could be tracked by an accessible error state which other components can use to disable on an invalid entry.
What will change?
Depending on implementation methods, this may change component interface, behaviour of committing an invalid value, etc.
Interface changes (if any)
Potentially, but undetermined.
Breaking change?
- Yes
- No
Next steps
A maintainer will review this issue.
If accepted, it will be marked as accepted and a PR may then be opened.
- Dominant language
- TypeScript
- Stars
- 8
- Forks
- 3
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 11
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from DiamondLightSource/sci-react-ui
-
needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
needs-triage
Difficulty 4/5 3-5 days Newbie friendliness 55/100
-
accepted
Difficulty 4/5 3-5 days Newbie friendliness 68/100
-
needs-triage
Difficulty 5/5 Over a week Newbie friendliness 45/100
-
needs-triage
Difficulty 4/5 3-5 days Newbie friendliness 48/100
DiamondLightSource/sci-react-ui#276 · 2 comments ·
All issues in DiamondLightSource/sci-react-ui
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Eynzof/Hermes-CN-Desktop#610 ·
-
bug clawsweeper:linked-pr-open clawsweeper:needs-live-repro clawsweeper:no-new-fix-pr impact:message-loss issue-rating: 🐚 platinum hermit P2 regression
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
calcite-components needs triage refactor
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Esri/calcite-design-system#15203 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
fullcalendar/fullcalendar#8106 ·