Check if it is possible to filter invalid events immediately

Open
#101 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
data-engineering

Research direction

Start by reading the discussion on PR #100 and the code referenced around line 664. Determine whether invalid events can be filtered immediately without affecting the processing that occurs between calculation and removal. Done means establishing whether the earlier filtering is safe and documenting or implementing the agreed change.

Written by the indexing model from the issue text.

Description

See @keeble's comment on PR #100

  Is there any reason to not filter the invalid events immediately? We calculate here but then do a bit more before removing them on 664

Originally posted by @keeble in https://github.com/DiamondLightSource/python-tristan/pull/100#discussion_r1191330605

Dominant language
Python
Stars
2
Forks
1
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from DiamondLightSource/python-tristan

All issues in DiamondLightSource/python-tristan

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.