DiamondLightSource/dodal

Remove conversion from string to DetectorSizeConstants in DetectorParams

Open

#717 opened on Jul 29, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (12 forks)auto 404
buggood first issuelow priority

Repository metrics

Stars
 (4 stars)
PR merge metrics
 (PR metrics pending)

Description

We used to need to be able to accept a string as DetectorSizeConstants as it was a parameter from GDA but this is now used as a constant in Hyperion so we can remove the need to derive it from a string.

Acceptance Criteria

  • Remove ability to specify DetectorSizeConstants as a string
  • DetectorParams still converts to json and back ok

Contributor guide

Research direction
Remove the string to DetectorSizeConstants conversion in DetectorParams and ensure JSON serialization still works.
Tech stack
python
Domain
backendapi
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75