DiamondLightSource/dodal

Connection tests as CI cronjob

Open

#507 opened on May 7, 2024

View on GitHub
 (3 comments) (1 reaction) (0 assignees)Python (12 forks)auto 404
enhancementgood first issuepython

Repository metrics

Stars
 (4 stars)
PR merge metrics
 (PR metrics pending)

Description

As a developer I would like to be kept apprised of the ongoing accuracy of the system tests and hence the PV definitions on the beamline so that I can correct errors when PVs change.

Should consider how best to setup CI accounting for:

  • Keeping PVs read-only so we don't affect the beamline
  • Deciding whom to notify of specific failures
  • One big CI job or one per beamline?

Acceptance Criteria

  • Local CI croniob that pulls dodal (all branches/PRs) and runs the connection tests (see #506) reporting any errors.

Contributor guide

Research direction
Investigate the existing CI setup in the dodal repository (likely GitHub Actions) and design a cronjob that runs the connection tests from #506 for all branches/PRs. Consider notification methods (e.g., Slack, email) and how to keep PVs read only. Decide whether to have one big job or per beamline.
Tech stack
python
Domain
ci cd
Issue type
DevOps
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitPythonCI/CD concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40