DiamondLightSource/dodal

Truncate flux to 0

Open

#386 opened on Mar 17, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (12 forks)auto 404
good first issue

Repository metrics

Stars
 (4 stars)
PR merge metrics
 (PR metrics pending)

Description

When there is no beam the flux PV can read as negative (https://ispyb.diamond.ac.uk/dc/visit/cm37235-2/id/13451673). This is potentially confusing for users and not immediately obvious that there is no beam. We should create two signals on the device, raw flux and then a flux that just reads 0 if the raw flux is very small or negative. Hyperion should then use the 0 reading one anytime it needs to read flux.

Acceptance Criteria

  • There is a signal on the flux device that reliably reads zero when there is no beam
  • This signal is used in Hyperion when reading flux

Contributor guide

Research direction
Inspect the existing flux device in dodal to understand how raw flux is read. Create a new signal that truncates negative values to zero. Modify Hyperion to use this new signal when reading flux.
Tech stack
python
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75