DiamondLightSource/dodal

Move mock aperture scatterguard logic into the mock device

Open

#1,764 opened on Dec 8, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (12 forks)auto 404
good first issue

Repository metrics

Stars
 (4 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently there is quite a bit of logic in tests/devices.conftest that is used to give a vaguely usable aperture_scatterguard device. Similar logic also exists in mx-bluesky. Following https://github.com/bluesky/ophyd-async/issues/1039 we can now make this logic the default for the device and remove it from the tests of dodal/mx-bluesky.

Acceptance Criteria

  • When you create a mock ApertureScatterguard you get something like the one created in the conftest
  • The logic for this is no longer added in both the dodal and mx-bluesky tests

Contributor guide

Research direction
Examine the mock aperture scatterguard logic in tests/devices.conftest and the related changes from issue #1039. Understand how to make that logic the default in the ApertureScatterguard device class, then remove the duplicated logic from both dodal and mx bluesky test suites.
Tech stack
python
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonOphydpytest
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75