DiamondLightSource/dodal

Add (real) unit tests to hutch shutter devices

Open

#1,066 opened on Feb 21, 2025

View on GitHub
 (0 comments) (0 reactions) (1 assignee)Python (12 forks)auto 404
good first issuei19-1i19-2

Repository metrics

Stars
 (4 stars)
PR merge metrics
 (PR metrics pending)

Description

In recent discussion of an i19 plan for control of the hutch shutter it was determined that unit tests belong in dodal and might currently be absent

Acceptance Criteria

  • When tests cover the behaviour of hutch shutters ( including those for i19 ) at the unit level ( existing tests cover behaviour already )

Contributor guide

Research direction
Examine existing unit tests in the dodal repository for similar devices (e.g., other shutters). Write new unit tests for hutch shutter devices using pytest, covering the behavior described for i19. Follow the existing test patterns and structure.
Tech stack
python
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Pythonpytest
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75