DiamondLightSource/dodal

Update `focusing_mirror` to use `set_and_wait_for_other_value`

Open

#1,016 opened on Jan 24, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (12 forks)auto 404
good first issue

Repository metrics

Stars
 (4 stars)
PR merge metrics
 (PR metrics pending)

Description

focusing_mirror has some code in the set to avoid a race condition. We should be able to use set_and_wait_for_other_value to do this (see https://github.com/bluesky/ophyd-async/issues/453) for this instead.

Acceptance Criteria

  • focusing_mirror uses inbuilt code in ophyd_async to avoid race conditions

Contributor guide

Research direction
Examine the current implementation of focusing mirror's set method and replace the race condition avoidance code with set and wait for other value from ophyd async, following the pattern in issue #453.
Tech stack
python
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80