Discussion: Should we allow converters that go to dict as well as converters that go to basemodels?
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
Research direction
Start by reading the linked discussion on pull request #129 and tracing the current converter behavior described there. Decide whether converters to dict and BaseModel should both be allowed; if changes are needed, update the relevant implementation and tests, but the issue names no files or tests.
Written by the indexing model from the issue text.
Description
This is the current behaviour, but could cause confusion. See comment
Acceptance Criteria
- Decide and make changes if needed
- Dominant language
- Python
- Stars
- 1
- Forks
- 2
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from DiamondLightSource/daq-config-server
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
-
enhancement
DiamondLightSource/daq-config-server#176 · 1 comment · 1 assignee ·
-
enhancement
DiamondLightSource/daq-config-server#175 · 1 comment · 1 assignee ·
-
Dependency Dashboard Open
Difficulty 3/5 1-2 days Newbie friendliness 25/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
All issues in DiamondLightSource/daq-config-server
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100