Providing a numpy ndarray view onto a non-contiguous bit of memory

Open
#1 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
numpy, python
Domain
backend

Research direction

Start by locating the memcpy that copies into the NumPy NDArray and compare it with NumPy's PyArray_CopyInto API documentation. Done means the non-contiguous-memory path uses that API instead of memcpy and preserves the intended ndarray contents; no file or test is named in the issue.

Written by the indexing model from the issue text.

Description

We do a memcpy to get the numpy array int an NDArray, we should be using:

https://docs.scipy.org/doc/numpy/reference/c-api.array.html#c.PyArray_CopyInto

Dominant language
Python
Stars
0
Forks
4
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from DiamondLightSource/adPython

All issues in DiamondLightSource/adPython

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.