Augment the fixed frequency NCOs by a sweep function
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Domain
- embedded-iot
Research direction
Start by locating the driver and gateware for the two fixed-frequency NCOs, then compare their implementation with the sweep function in the sequencer. Define the listed START_FREQ, STEP_FREQ, END_FREQ, COUNT, DWELL, and HOLDHOFF PVs for both NCOs, remove FREQ, and verify the version 1.4.3 changes work for both NCOs.
Written by the indexing model from the issue text.
Description
As suggested by @Araneidae in #21 the two fixed frequency NCOs could be augmented by implementing a sweep function instead. This functionality could be of interest for Elettra (@lonzam), and would be useful for the ESRF as part of the bunch cleaning system.
This requires a change of the driver and gateware, which could become version 1.4.3
I propose to use a very similar implementation of the sweep function used in the sequencer.
The following new PVs would be defined for NCO1:
- (MBF):(AXIS):NCO1:START_FREQ
- (MBF):(AXIS):NCO1:STEP_FREQ
- (MBF):(AXIS):NCO1:END_FREQ
- (MBF):(AXIS):NCO1:COUNT
- (MBF):(AXIS):NCO1:DWELL
- (MBF):(AXIS):NCO1:HOLDHOFF
The former PV will be removed:
- (MBF):(AXIS):NCO1:FREQ
The same will be done for NCO2.
Comments and suggestions are welcome.
edit: add PV COUNT
- Dominant language
- VHDL
- Stars
- 4
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from DiamondLightSource/DLS-MBF
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
DiamondLightSource/DLS-MBF#24 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 15/100
DiamondLightSource/DLS-MBF#14 · 1 comment ·
-
bug enhancement
Difficulty 5/5 Over a week Newbie friendliness 20/100
All issues in DiamondLightSource/DLS-MBF
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
new device support
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Koenkk/zigbee2mqtt#33176 · 1 comment ·
-
status:needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
PX4/PX4-Autopilot#28776 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
zephyrproject-rtos/zephyr#119726 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 76/100