SetCurrentItem without animation

Open Beginner friendly
#62 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
android, java
Domain
mobile-dev

Research direction

Locate the Java implementation of setCurrentItem(int item, boolean smoothScroll) and compare the smoothScroll parameter with the boolean passed to mInfiniteCycleManager and the superclass. Ensure the requested animation setting is honored, then verify that both animated and non-animated calls behave as expected.

Written by the indexing model from the issue text.

Description

I found a mistake where variable 'smoothScroll' is not used but 'true' is passed to mInfiniteCycleManager.setCurrentItem

@Override
public void setCurrentItem(final int item, final boolean **smoothScroll**) {
    if (mInfiniteCycleManager != null)
        super.setCurrentItem(mInfiniteCycleManager.setCurrentItem(item), **true**);
}
Dominant language
Java
Stars
5.7k
Forks
821
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Devlight/InfiniteCycleViewPager

All issues in Devlight/InfiniteCycleViewPager

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.