DeviaVir/zenbot

--order_type=auto

Open

#268 opened on Jun 11, 2017

View on GitHub
 (2 comments) (4 reactions) (0 assignees)HTML (8,212 stars) (2,041 forks)batch import
enhancementhelp wanted

Description

Hi, I missed the pull the request of the --order_type parameter, but I would like to share this idea. How about an automatic order_type? The bot will start with no fee type (maker), when if the slippage cross one defined value the bot will make the fee order (taker). In most cases the bot sell/buy without any slippage and sometimes with positive slippage, which is nice. We could for example set a maximum slippage of -0.01%, and if the slippage cross that value the bot will sell/buy with the taker type order.

What do you think?

Contributor guide

Tech stack
nodejsmongodb
Domain
clibackend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Basic cryptocurrency trading knowledgeZenbot codebase structureNode.js and MongoDB basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate the existing order type parameter implementation in the codebase, likely in configuration files and order execution logic. Review any related issues or pull requests for context. Determine how slippage is currently calculated and how to add a threshold based switch between maker and taker orders. Consider discussing with maintainers to clarify desired behavior and acceptance criteria.