DefGuard/defguard

Do not display "invalid password" in logs

Open

#712 opened on Aug 9, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (107 forks)auto 404
buggood first issue

Repository metrics

Stars
 (2,779 stars)
PR merge metrics
 (PR metrics pending)

Description

Providing correct login with incorrect password shows in logs that user provides invalid password.

  • Display in logs invalid username or password
  • Add also red border for username when a user type wrong password with correct username

Contributor guide

Research direction
Find the log statement in the authentication handler and update it to hide whether the username or password is invalid. Then locate the frontend code for the login form and add a red border to the username field when authentication fails.
Tech stack
rust
Domain
authenticationbackend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitRust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80