When serverSide is on not all selected items are being selected

Open
#46 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
frontend

Research direction

Start in js/dataTables.select.js at the preXhr.dt listener around line 606, then reproduce the behavior with serverSide enabled across more than two consecutive XHR requests. Done means the complete selected-item list is preserved so previously selected items remain selected after subsequent requests.

Written by the indexing model from the issue text.

Description

Hi.
I believe I stumbled on a bug.
The preXhr listener preXhr.dt
attempts to give a solution to keeping the selected items in place when serverSide is on.
The code misses to account for more than two consecutive xhr requests since the whole list of
selected items is not kept but rather only the list of selected in the current page.
Thanks

Dominant language
JavaScript
Stars
44
Forks
40
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from DataTables/Select

All issues in DataTables/Select

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.