Allow to configure fixed element container
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 48/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- frontend
Research direction
Start in js/dataTables.fixedHeader.js around line 285, where the issue identifies the floating footer being appended to body. Trace that placement logic and verify the requested configurable-container behavior against the form-contained markup shown in the issue, while preserving the existing default behavior.
Written by the indexing model from the issue text.
Description
We've got still some issues with form and FixedHeader/Footer (#68). Wouldn't it be sufficient to make the container configurable? At the moment the floating footer get's appended to body. If we'd move it out of the table into the surrounding form it'll still work out-of-the-box:
Before DT triggers:
<body>
<form>
<table>
<tbody><!-- some rows --></tbody>
<tfoot><!-- some actions --></tfoot>
</table>
</form>
</body>
Current version:
<body>
<form>
<table>
<tbody><!-- some rows --></tbody>
</table>
</form>
<table>
<tfoot><!-- some actions --></tfoot>
</table>
</body>
Alternate solution:
<body>
<form>
<table>
<tbody><!-- some rows --></tbody>
</table>
<table>
<tfoot><!-- some actions --></tfoot>
</table>
</form>
</body>
https://github.com/DataTables/FixedHeader/blob/master/js/dataTables.fixedHeader.js#L285
Cheers
Matthias
- Dominant language
- TypeScript
- Stars
- 73
- Forks
- 83
- Avg merge
- 4m
- Merged PRs (30d)
- 1
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from DataTables/FixedHeader
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
DataTables/FixedHeader#110 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 38/100
DataTables/FixedHeader#105 · 26 comments · 1 reaction ·
-
Difficulty 3/5 1-2 days Newbie friendliness 40/100
DataTables/FixedHeader#103 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
DataTables/FixedHeader#102 ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
DataTables/FixedHeader#98 · 8 comments · 1 reaction ·
All issues in DataTables/FixedHeader
Similar issues
-
blocklist removal
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
MetaMask/eth-phishing-detect#296544 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
pastelsky/bundlephobia#1122 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
category/development priority/P2 scope/file-operations scope/testing type/enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Enatega Customer and Rider app: Add-ons price is not visible to customer after order is placed. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100