DevTools marker disappears while another wrapper remains active
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 74/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- typescript
- Domain
- tooling
Research direction
Start by locating the DatadogDevtools wrapper and its onClose() handling for the dd.dd_flag.devtools localStorage marker. Reproduce replacement within one OpenFeature domain and across two domains, then inspect the proposed regression cases. Done means the marker remains while any wrapper is active and is removed after the last wrapper closes.
Written by the indexing model from the issue text.
Description
I noticed that replacing one DatadogDevtools provider with another removes the DevTools marker from localStorage, even though the new provider is still active.
To reproduce:
- Register a provider wrapped in DatadogDevtools.
- Checking localStorage.getItem('dd.dd_flag.devtools') returns "enabled".
- Replace it with another provider wrapped in DatadogDevtools.
- Check the marker again and it returns
null, but the new provider still evaluates flags successfully.
I also tried registering wrappers in two separate OpenFeature domains. Replacing either one with an unwrapped provider removes the marker while the other wrapper is still active.
I’d expect the marker to stick around until the last DevTools wrapper closes. It looks like each wrapper currently removes it when its own onClose() runs.
I have a small fix and regression tests for both cases, including cleanup after the last wrapper closes. Happy to send a PR if that would be useful.
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 3
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 9
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from DataDog/openfeature-js-client
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
DataDog/openfeature-js-client#151 ·
All issues in DataDog/openfeature-js-client
Similar issues
-
calcite-components needs triage refactor
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Esri/calcite-design-system#15203 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 91/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100