Update DEFAULT_HTTP_CLIENT_ERROR_STATUSES to include 5xx status codes
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 70/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- java
- Domain
- observability-sre
Research direction
Open dd-trace-api/src/main/java/datadog/trace/api/ConfigDefaults.java at lines 27–28 and inspect the current DEFAULT_HTTP_CLIENT_ERROR_STATUSES value. Update the default so 5xx responses are included, then verify that downstream HTTP client metrics classify those responses as errors.
Written by the indexing model from the issue text.
Description
Library Name
No response
Library Version(s)
No response
Describe the feature you'd like
Update the default HTTP client error status codes to include 5xx errors. https://github.com/DataDog/dd-trace-java/blob/7e509612d55c6bc155c62f8ea4b41b4f03c5a3a6/dd-trace-api/src/main/java/datadog/trace/api/ConfigDefaults.java#L27-L28
Is your feature request related to a problem?
No response
Describe alternatives you've considered
No response
Additional context
With the addition of inferred services, trace metrics from http clients will show up as part of the calling service. These metrics are used to show latency metrics to downstream services. Right now the errors that are shown only apply to 4xx errors. This is misleading as 5xx errors do not show in the UI as an error for downstream calls to other services.
- Dominant language
- Java
- Stars
- 737
- Forks
- 361
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 147
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from DataDog/dd-trace-java
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
DataDog/dd-trace-java#12540 · 2 comments · 1 assignee ·
-
Difficulty 3/5 1-2 days Newbie friendliness 25/100
DataDog/dd-trace-java#12480 ·
-
comp: tooling type: bug report
DataDog/dd-trace-java#12469 · 1 reaction · 1 assignee ·
-
Difficulty 3/5 1-2 days Newbie friendliness 75/100
DataDog/dd-trace-java#12390 ·
-
inst: websocket type: feature
Difficulty 4/5 3-5 days Newbie friendliness 52/100
DataDog/dd-trace-java#12378 ·
All issues in DataDog/dd-trace-java
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
checkstyle/test-configs#263 ·
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 90/100
apache/cloudstack#14222 ·
-
[BUG]茶杯方块在取茶时会引发崩溃 Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
1.0.0-alpha2 Type/Improvement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
wso2/dpdp-accelerator#272 ·