[Question] WriteAtrribute to be inherited

Open
#165 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
csharp
Domain
backend, database

Research direction

Start with the WriteAttribute declaration and the described behavior for base and derived classes; review Dapper issue #934 for the workaround context. Done means confirming whether inheritance is intended and, if accepted, agreeing on a pull request to change the attribute.

Written by the indexing model from the issue text.

Description

So I've been working with a workaround to Dapper's issue #914 and while I completed it succesfully for my code I encountered that WriteAttribute(false) attribute is not inherited by derived classes and I need this for the workaround to work succesfully. For now I have the property of the base class marked as abstract and each child class implements it the same way and adds the WriteAttribute(false)

My question is: Is this the intended behaviour and if I want this behaviour I should fork the project for my use-case or should I add the Inherited = True to the WriteAttribute and do a Pull Request? (Y'all have plenty of work and I know this is not the priority now as the priority is DapperAot).

Dominant language
C#
Stars
293
Forks
109
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from DapperLib/Dapper.Contrib

All issues in DapperLib/Dapper.Contrib

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.