Inherited TableAttribute is ignored by CRUD operations

Open

#153 opened on Dec 30, 2022 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 2/5
Estimated time: 1-3 hours
Newbie friendliness: 48/100

Issue type: Bug
Clarity: Mostly clear
Activity status: Stale
Tech stack: csharp
Domain: database

Research direction

Start in src/Dapper.Contrib/SqlMapperExtensions.cs at GetTableName and compare its CustomAttributes handling with the ExplicitKeyAttribute handling around the referenced lines. Verify how inherited TableAttribute values flow through CRUD operations and determine whether those operations should use the inherited table name rather than requiring TableMapper or repeated attributes.

Written by the indexing model from the issue text.

Description

The TableAttribute is inherited to subclasses but then ignored by the CRUD operations. This is due to the method SQLMapperExtensions.GetTableName ignoring inherited CustomAttributes.

https://github.com/DapperLib/Dapper.Contrib/blob/cf24f6bdc577b1e071c3764ddfb2cf3382531405/src/Dapper.Contrib/SqlMapperExtensions.cs#L290-L293

This feels wrong since the attribute is actually being inherited and attributes on property level are not being ignored, e.g.: properties with ExplicitKeyAttribute

https://github.com/DapperLib/Dapper.Contrib/blob/cf24f6bdc577b1e071c3764ddfb2cf3382531405/src/Dapper.Contrib/SqlMapperExtensions.cs#L87-L98

Currently you have to either specify the table name for every subclass or make use of SQLMapperExtensions.TableMapper.
Is this behaviour wanted?

Dominant language: C#
Stars: 293
Forks: 109
PR merge metrics: No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

[quality-improver] Repository Quality: AzureFoundry Extension Missing from Self-Registration Acceptance Test Open

type/automation type/tech-debt

Difficulty 2/5 1-3 hours Newbie friendliness 78/100

microsoft/testfx#11431 · Opened Sep 21, 2026
[Bug]: Composite `ui screenshot` success output ignores `--quiet` Open

bug

Difficulty 2/5 1-3 hours Newbie friendliness 88/100

microsoft/winappCli#914 · Opened Sep 21, 2026
GeometryHelper.FlattenArc / FlattenCubicBezier / FlattenQuadraticBezier emit a NaN point when the segment count truncates to 0 (0/0) — a Path with a sub-pixel arc fail-fasts Windows with D2DERR_BAD_NUMBER (root cause of #8512, #13757) Open

t/bug

Difficulty 2/5 1-3 hours Newbie friendliness 82/100

dotnet/maui#38751 · 1 reaction · Opened Sep 21, 2026
[CI Failure] Flaky: MauiBuildQueueTests.CancelQueuedResource_CompletesGracefullyAndDoesNotAcquireSemaphore asserts exact exception type but sometimes gets TaskCanceledException instead of OperationCanceledException Open

ci-failure-cause test-failure

Difficulty 2/5 1-3 hours Newbie friendliness 82/100

microsoft/aspire#20284 · Opened Sep 21, 2026
The login flow's text-link submit is 42 px tall on a narrow screen; its docblock says 44 Open

area:auth FE mvp P3

Difficulty 2/5 1-3 hours Newbie friendliness 88/100

klasolsson81/jobbliggaren#1788 · Opened Sep 21, 2026

More C# issues