Unnecessary use of SkipListAccessor in TPRequestHandler::periodic_data_transmission() ?
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 42/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- cpp
- Domain
- performance
Research direction
Start in src/TPRequestHandler.cpp at periodic_data_transmission() and inspect how get_fragment_pieces() creates its SkipListAccessor through lower_bound. Compare that with the existing front() and back() usage in other datahandling locations. Done means determining whether the extra accessor can be removed without changing timestamp handling, then checking the datahandlinglibs issue for relevant performance effects.
Written by the indexing model from the issue text.
Description
My understanding of SkipList node removal is that it is done lazily, removing nodes that have been marked for removal only after all SkipListAccessors, so creating accessors more than needed induces some overhead and may reduce some ability to get cleanup done.
I don't know if removing this will help much with the performance issue noted here https://github.com/DUNE-DAQ/datahandlinglibs/issues/62, but I don't think the accessor created here is really necessary: get_fragment_pieces() will create an accessor when it gets its lower_bound iterator, and so if we only need to get the best understanding of the timestamps, then we should be able to call front() and back() here (as is done in other datahandling places).
If others agree, we might try to remove this here, and then see if that helps (or at least doesn't hurt) the cleanup situation.
- Dominant language
- C++
- Stars
- 0
- Forks
- 8
- Avg merge
- 7h 21m
- Merged PRs (30d)
- 3
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from DUNE-DAQ/trigger
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
All issues in DUNE-DAQ/trigger
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
AXERA-TECH/ax-llm#77 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
games-on-whales/wolf#509 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
bug-unconfirmed
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
NVIDIA/cuda-samples#453 ·