enums for site type, county, etc.

Open
#98 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
api

Research direction

Start by reading dataretrieval/nwis.py at the linked site type and county code definitions, then review the related proposal in #97. Determine which values should become enums and how that change fits the existing API; done means the scope and enum design are agreed, since this issue currently asks for discussion rather than specifying an implementation.

Written by the indexing model from the issue text.

Description

How do we feel about using enum for site type, county code, etc., instead of str?

It would fit nicely with:

  • #97
Dominant language
Python
Stars
266
Forks
63
Avg merge
1d 20h
Merged PRs (30d)
19

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from DOI-USGS/dataretrieval-python

All issues in DOI-USGS/dataretrieval-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.