Existing config not compatible with DNSCrypt v2.1.1

Open
#557 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp

Research direction

Start by reproducing the failure with DNSCrypt v2.1.1 and an existing configuration, then trace the GUI path that writes the config and the handling of blacklist.txt. Done means the service loads without restoring the unsupported [daemonize] key, and the deprecated [blacklist] setting is handled according to the chosen user-facing approach.

Written by the indexing model from the issue text.

Description

The latest build of DNSCrypt fails to load due to config changes that the GUI is unaware of.
This means that the service will fail to load.
Once I enabled the error logging I got his error;
[FATAL] Unsupported key in configuration file: [daemonize]

Once manually removed from the config it will load, but if the UI is used to update the settings it will put it back.
Now it works I see other config error relating to blacklists;
[NOTICE] Use of [blacklist] is deprecated - Update your config file

However, my existing blacklist still seems to be loaded
[NOTICE] Loading the set of blocking rules from [C:\Program Files\bitbeans\Simple DNSCrypt x64\dnscrypt-proxy\blacklist.txt]

Looks like the next update will have to sanitise the config, or notify the users they need to reset the config, or do a clean install.

Dominant language
C#
Stars
2.5k
Forks
249
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from DNSCrypt/SimpleDnsCrypt

All issues in DNSCrypt/SimpleDnsCrypt

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.