ComparerCollection.sel(), time arg errors when selecting a month where some comparers have no temporal overlap
Assessment
This issue has not been assessed yet.
Description
Steps to reproduce:
This works:
import modelskill as ms
cc = ms.data.oresund()
cc.sel(time=slice("2022-01-03 00:00:00", "2022-01-03 00:00:00")
This fails:
import modelskill as ms
cc = ms.data.oresund()
cc.sel(time=slice("2022-01-03")
Likely caused by this comparer failing:
cc["Koege"].sel(time=slice("2022-01-03")
Expected behaviour:
Should work the same way when using an explicit slice as using a implicit time period. Selecting a time period with no data should return an empty comparer, and on a comparer collection it gets removed (as it already works today).
- Dominant language
- Python
- Stars
- 56
- Forks
- 9
- Avg merge
- 57m
- Merged PRs (30d)
- 3
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from DHI/modelskill
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
DHI/modelskill#628 ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
DHI/modelskill#706 · 2 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
DHI/modelskill#700 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
DHI/modelskill#697 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
DHI/modelskill#689 · 1 comment ·
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100