pseudo_cl.py reads the n(z) path from the config directly, ignoring `self.blind`

Open Beginner friendly
#314 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
82/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
data

Research direction

Start with CosmologyValidation.get_redshift in core.py:383-410, then inspect the two direct redshift_path reads in pseudo_cl.py at lines 129 and 316 and compare them with pure_eb.py:117. Done means blind B or C uses the requested n(z) consistently for theory C_ell and Gaussian/OneCovariance products, rather than blind A.

Written by the indexing model from the issue text.

Description

CosmologyValidation.get_redshift (core.py:383-410) applies the blind by rewriting the _[ABC].txt suffix on redshift_path. pseudo_cl.py never calls it and never references blind at all: lines 129 and 316 read self.cc[ver]["shear"]["redshift_path"] directly.

Consequence: with blind="B" or "C", the theory C_ell and the Gaussian/OneCovariance products are built from blind A's n(z), while pure_eb.py:117 honours the requested blind in the same run. Silent — same filenames, same shapes, no error. Harmonic space is therefore not actually blinded, and a non-A run is internally inconsistent between its config-space and harmonic-space products.

The fix is to go through self.get_redshift(ver) (or a shared path accessor) at both sites. #312 will retire this blinding vocabulary wholesale; until that lands the current behaviour is wrong rather than merely legacy.

Dominant language
Python
Stars
2
Forks
5
Avg merge
1d 14h
Merged PRs (30d)
19

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from CosmoStat/sp_validation

All issues in CosmoStat/sp_validation

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.