CommunityToolkit/WindowsCommunityToolkit

WeakEventListener in NetworkConnectionStateTrigger is duplicated

Open

#4,059 opened on Jun 1, 2021

View on GitHub
 (1 comment) (0 reactions) (1 assignee)C# (1,403 forks)batch import
Hacktoberfestbug :bug:good first issuehelp wantedimprovements :sparkles:

Repository metrics

Stars
 (5,708 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Describe the bug

Looks like NetworkConnectionStateTrigger is using a private copy of WeakEventListener, it's identical to the one we already have in the Toolkit, so we should update the source to use the existing code within the Toolkit.

https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/ebb12e0c38c22ec01849e202f8e477d8c1a67061/Microsoft.Toolkit.Uwp.UI/Triggers/NetworkConnectionStateTrigger.cs#L73

Expected behavior

Use existing code over shadow copy.

https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/ebb12e0c38c22ec01849e202f8e477d8c1a67061/Microsoft.Toolkit.Uwp/Helpers/WeakEventListener.cs#L17

Contributor guide

Research direction
Replace the private WeakEventListener class in NetworkConnectionStateTrigger with the existing WeakEventListener from Microsoft.Toolkit.Uwp.Helpers, updating the code to use the shared implementation.
Tech stack
csharp
Domain
frontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85