CommunityToolkit/WindowsCommunityToolkit

Current WCT solution does not build when .NET 5 preview is installed

Open

#3,339 opened on Jun 10, 2020

View on GitHub
 (8 comments) (1 reaction) (0 assignees)C# (1,403 forks)batch import
bug :bug:build :fire:help wanted

Repository metrics

Stars
 (5,708 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Describe the bug

When building the Microsoft.Toolkit.Services project, the WPFPopup XAML page for the net462 target is not getting its .i.g.cs content generated properly, causing missing members compilation errors.

Steps to Reproduce

Install .NET 5.0.100-preview.6.20277.5, build the solution.

Additional context

This looks like a .NET 5 issue, where the MarkupCompilePass1 does not seem to be executed at all, even though Page ItemGroup items are present.

As a workaround, adding this to the global.json file works around the issue:

  "sdk": {
    "version": "3.1.201",
    "rollForward": "latestPatch"
  },

Contributor guide

Research direction
Investigate why MarkupCompilePass1 is not executed when .NET 5 preview SDK is installed. Compare the MSBuild targets between .NET 5 preview and .NET Core 3.1 SDK to identify the cause.
Tech stack
csharp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git.NET SDK
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65