CommunityToolkit/WindowsCommunityToolkit

GridSplitter adding width to column will make grid overflow

Open

#1,894 opened on Mar 15, 2018

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C# (5,708 stars) (1,403 forks)batch import
bug :bug:controls :control_knobs:help wantedin progress :construction:

Description

I'm submitting a...

Current behavior

Adjusting the splitter when the second column has a default width will make the grid overflow when dragged right then left.

Expected behavior

Splitter respects the root grid bounds.

Minimal reproduction of the problem with instructions

Using GridSplitter in UWP Community Toolkit Sample App. Change line 19 and 20 to:

<ColumnDefinition Width="120" />
<ColumnDefinition MinWidth="100" />

Drag vertical splitter right then left. It will allow you to resize the second column all the way to the right edge of the widow hiding the third column.

Environment

Nuget Package(s): 
Microsoft.Toolkit v2.2.0
Microsoft.Toolkit.Uwp v2.2.0
Microsoft.Toolkit.Uwp v2.2.0
Microsoft.Toolkit.Uwp.Controls v2.2.0

Package Version(s): 

Windows 10 Build Number:
- [ ] Anniversary Update (14393) 
- [ ] Creators Update (15063)
- [X ] Fall Creators Update (16299)
- [ ] Insider Build (build number: )

App min and target version:
- [ ] Anniversary Update (14393) 
- [ ] Creators Update (15063)
- [X ] Fall Creators Update (16299)
- [ ] Insider Build (xxxxx)

Device form factor:
- [ X] Desktop
- [ ] Mobile
- [ ] Xbox
- [ ] Surface Hub
- [ ] IoT

Visual Studio 
- [X ] 2017 (version: 15.6.1)
- [ ] 2017 Preview (version: )

Contributor guide

Tech stack
csharp
Domain
desktopfrontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
UWP app developmentGrid layout basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The issue involves the GridSplitter control's resize logic. The reporter provides specific steps: modify ColumnDefinition widths to 120 and MinWidth=100 for second column, then drag right then left. The grid overflows, hiding the third column. To fix, examine the GridSplitter source code in the repository (likely in Microsoft.Toolkit.Uwp.UI.Controls.GridSplitter). The resize behavior should respect the root grid bounds and prevent overflow. Check the calculation of column widths during drag, especially when columns have MinWidth constraints. Linked comments may contain further analysis or attempted fixes.