SqliteVec BuildInsertCommand is slow as it does not reuse a single command for inserts
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 68/100
Research direction
Start in MEVD/src/SqliteVec/SqliteCommandBuilder.cs, especially the cited lines around BuildInsertCommand and its parameter construction. Trace how insert commands are built and executed, then verify that the command text and parameter bindings remain reusable across records while key-returning and non-returning paths behave as expected.
Written by the indexing model from the issue text.
Description
BuildInsertCommand constructs a chained multi-row INSERT with record-index-suffixed parameter names for every batch, so the CommandText and parameter names change with every call and Microsoft.Data.Sqlite cannot reuse any prepared statement, re-preparing all statements and allocating all parameters per batch.
Steps to reproduce
- Create a collection with a string key, one data property and a 256-dimension vector.
- Upsert batches of 200 records repeatedly and profile, or simply inspect the DbCommand produced by a batch.
- Observe the CommandText: Rather than one insert statement that is reused for each record, it is multiple statements, one statement per record, with parameter names like @Content13 embedding the record index, and it differs for every batch.
Expected behavior
The SQL text for an insert is stable across records so the provider's per-command prepared statement cache and parameter bindings can be reused, and only values are re-bound per record.
Actual behavior
Every batch builds a multi-kilobyte CommandText and a large set of SqliteParameter objects. For a 200-record batch 200 statements are added to the CommandText.
Analysis
The connector builds one INSERT per record inside a loop over the records, and derives parameter names from the record index:
Microsoft.Data.Sqlite caches prepared statements on the SqliteCommand instance and reuses them only while the CommandText is unchanged. Because the generated text embeds per-record parameter names and grows with the batch, no reuse across records is possible.
Additionally the data insert always runs through ExecuteReaderAsync even when no database-generated key needs to be read back, adding a reader allocation and result-set handling per batch.
Cause
Statement preparation cost scales with the number of records per batch, per operation, because the command is both rebuilt per operation and structured so each record has its own uniquely named parameters.
Possible fix
Build one fixed single-row INSERT command per table per operation (INSERT OR REPLACE INTO "t" (...) VALUES (@Key, @Content, ...)), prepare it once, and loop over the records re-binding parameter values only. Keep a RETURNING variant only for the database-generated int or long key case, and use ExecuteNonQueryAsync otherwise.
Environment
- OS: Windows 11 and Linux
- Package: CommunityToolkit.VectorData.SqliteVec 1.0.1-preview
- Microsoft.Data.Sqlite 10.x, sqlite-vec 0.1.7-alpha.2.1
- Dominant language
- C#
- Stars
- 7
- Forks
- 4
- Avg merge
- 10m
- Merged PRs (30d)
- 2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from CommunityToolkit/AI
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
CommunityToolkit/AI#19 ·
-
CommunityToolkit/AI#52 · 2 comments · 1 assignee ·
-
CommunityToolkit/AI#23 · 1 assignee ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
CommunityToolkit/AI#20 ·
-
Difficulty 5/5 Over a week Newbie friendliness 38/100
CommunityToolkit/AI#13 ·
All issues in CommunityToolkit/AI
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
nightscout/nocturne#1425 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Documentation
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
cake-build/cake#5024 ·
-
Frontend status/draft TechnicalDebt
Difficulty 2/5 1-2 days Newbie friendliness 75/100
Altinn/altinn-auth#4143 ·