TreeDataGrid - Entirety of group row to trigger toggling

Open
#3,796 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
react, typescript
Domain
frontend

Research direction

Start with the TreeDataGrid and the RowGrouping example linked in the issue, reproducing the behavior with a horizontally scrolled group row. Trace how clicking the first cell triggers toggling versus clicks on other cells; done means every cell in the group row toggles the group consistently.

Written by the indexing model from the issue text.

Description

Use case

When using the TreeDataGrid (latest version), I have to click on the first cell of the group row in order to toggle it. Clicking on the rest of the row (on any of the cells ) doesn't do anything.

This can be seen here: https://adazzle.github.io/react-data-grid/#/RowGrouping.

If I click on the cell of Zimbabwe, the toggle works as expected. However, if I click on any other cell, the toggle isn't triggered.

Proposed solution

I would like for the whole group row's cells to perhaps have the click handler to trigger the toggling.

Use case

This would be useful for big grids (on smaller screens), where horizontal scrolling takes place, and the initial group column goes out of view.

Dominant language
TypeScript
Stars
7.7k
Forks
2.2k
Avg merge
1d 10h
Merged PRs (30d)
30

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Comcast/react-data-grid

All issues in Comcast/react-data-grid

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.