Add top and left to cell editor props back

Open
#2,664 6 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
react, typescript
Domain
frontend

Research direction

Start by reviewing CellEditorProps and PR #2420, then trace how portal-rendered custom editors determine their position. Decide whether restoring top and left or using the current cell as the default portal target matches the intended API, and verify that a custom editor can render below the cell without a user-supplied target.

Written by the indexing model from the issue text.

Description

Use case

The top and left properties were removed (PR #2420) from CellEditorProps which is taking away an important functionality to have custom editor with portal rendered at the cell position. We want to have a custom editor that opens at (right below) the cell position. The top and left properties are useful in positioning the cell editor at desired location when editor is rendered with portal and possibly floating on/below the cell itself.

Proposed solution

  1. Add top and left back to CellEditorProps. OR
  2. When creating editor with portal, use current cell as the portal target (instead of Body) if user does not provide their custom portal target.
Dominant language
TypeScript
Stars
7.7k
Forks
2.2k
Avg merge
1d 10h
Merged PRs (30d)
30

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Comcast/react-data-grid

All issues in Comcast/react-data-grid

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.