Updating selectedRows property on onRowClick event stops double click from working

Open
#2,540 9 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
react, typescript
Domain
frontend

Research direction

Start by reproducing the behavior with the DataGrid configuration and rowClickHandler shown in the issue, focusing on the interaction between selectedRows updates and double-click cell editing. Trace the DataGrid row-click and edit entry points; done means selecting a row on click no longer prevents double-clicking a cell to edit it.

Written by the indexing model from the issue text.

Description

I have a data grid setup like following:

<DataGrid
        rowKeyGetter={rowKeyGetter}
        columns={columns}
        rows={rows}
        onRowsChange={setRows}
        selectedRows={selectedRows}
        onSelectedRowsChange={setSelectedRows}
        rowRenderer={RowRenderer}
        onSelectedCellChange={selectedCellChange}
        onRowClick={rowClickHandler}
        rowHeight={30}
></DataGrid>

I want to set selected rows on row click and not on checkbox click:

  const [selectedRows, setSelectedRows] = useState<Set<number>>(() => new Set());

  function rowClickHandler(row: any) {
    let selectedRowsSet = new Set(selectedRows);
    if (selectedRowsSet.has(row.id)) {
      selectedRowsSet.delete(row.id);
    } else {
      selectedRowsSet.add(row.id);  
    }
    setSelectedRows(selectedRowsSet);
  }

But the above function disables functionality for double click to edit cell. I think it may be due to the state change that occurs when I call the setSelectedRows function to update selected row.

Is there any way in which I can click rows for selection and double click for cell edit to work ?

Dominant language
TypeScript
Stars
7.7k
Forks
2.2k
Avg merge
1d 10h
Merged PRs (30d)
30

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Comcast/react-data-grid

All issues in Comcast/react-data-grid

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.