Added circle command but i have questions.

Open
#75 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
javascript

Research direction

Start by reviewing the added circle command, then resolve the questions raised about ellipseMode(center) and whether the command should use width and height instead of a radius. Done means the command's API and implementation choices are confirmed by the project maintainer.

Written by the indexing model from the issue text.

Description

I have added the circle command, but this is my first time contributing to something on github, so please if you see that i have done something wrong, done something in a diffrent way than i should have, change it and let me know. I dont know if i should use ellipseMode(center) or not, or if i should use w,h instead of radius.

Dominant language
JavaScript
Stars
47
Forks
33
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from CodingTrain/Logo

All issues in CodingTrain/Logo

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.