2.0.0 silently dropped support for `grabFixture()` with numeric indices
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 67/100
Research direction
Start at the grabFixture() entry point and inspect the typing refactoring in commit baba62281f6839e1c21e646d50971156fd7b8faa, then compare it with the numeric-index fixture example linked in the issue. Done means integer indices remain supported, with regression coverage if the repository provides it; otherwise the compatibility change should be documented in the changelog or release notes.
Written by the indexing model from the issue text.
Description
https://github.com/Codeception/module-yii2/commit/baba62281f6839e1c21e646d50971156fd7b8faa, a typing refactoring, changed the type of grabFixture() $index param to string|null.
Historically though, this could also be an integer (like, if you just have a fixture array without keys) - see e.g. https://github.com/yiisoft/yii2-app-advanced/blob/8d10c0d2ff1c78c454cf649226ca8465a198902e/frontend/tests/Support/data/login_data.php .
Imho that support should not be dropped. And if that was intentional, it should be in CHANGELOG / release notes.
(yes, technically, using integers as string '0' might still work, but that's ugly)
- Dominant language
- PHP
- Stars
- 19
- Forks
- 43
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Codeception/module-yii2
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Codeception/module-yii2#144 · 1 comment · 1 reaction ·
-
MongoDB support Open
Difficulty 5/5 Over a week Newbie friendliness 25/100
Codeception/module-yii2#142 · 4 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 38/100
Codeception/module-yii2#141 · 1 comment ·
-
Codeception/module-yii2#134 · 4 comments · 1 assignee ·
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Codeception/module-yii2#95 · 1 reaction ·
All issues in Codeception/module-yii2
Similar issues
-
priority: p3
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
googleapis/librarian#7636 ·
-
0. Needs triage bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
nextcloud/fulltextsearch#1011 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
phpstan/phpstan-doctrine#794 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Automattic/static-site-importer#1767 ·