Suggesting building function before writing tests, contradicting task.

Open
#1,246 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
50/100
Issue type
Documentation
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript

Research direction

Compare the acceptance criteria in Sprint-3/1-implement-and-rewrite-tests with the linked implement/1-get-angle-type.js curriculum page. Confirm whether the intended habit is to write assertions and build the function incrementally, then update the task wording so the instructions do not suggest completing the function before testing. Done means the relevant instructions consistently describe the intended workflow.

Written by the indexing model from the issue text.

Description

:gear: bug 📅 Sprint 3 Module-Structuring-And-Testing-Data NotCoursework
Link to the curriculum page

https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/blob/main/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

Steps to reproduce

The original instructions for this backlog item mention:

Write your assertions and build up your program case by case. Don't rush to a solution. The point of these assignments is to learn how to write assertions and build up a program step by step.

Just checking, we definitely want to build testing habit of TDD? Looks like the acceptance criteria for the "implement" tasks should be saying to make tests and build the function as you go, but they currently suggest building the full function before working on tests.

Dominant language
JavaScript
Stars
0
Forks
397
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from CodeYourFuture/Module-Structuring-and-Testing-Data

All issues in CodeYourFuture/Module-Structuring-and-Testing-Data

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.