CodeGenieApp/serverless-express

[Bug]: `ConfigureParams` type is out-of-date.

Open

#365 opened on Feb 5, 2021

View on GitHub
 (4 comments) (2 reactions) (0 assignees)JavaScript (4,977 stars) (674 forks)batch import
bughelp wanted

Description

I was attempting to add a custom eventSource and was getting typehint failures as the eventSource isn't defined in the ConfigureParams type.

https://github.com/vendia/serverless-express/blob/mainline/src/configure.d.ts

Contributor guide

Tech stack
javascripttypescriptnodejsaws
Domain
backendcloudapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScript basicsProject type structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Look at the `src/configure.d.ts` file to see the current `ConfigureParams` type definition. Add the missing `eventSource` property to the type. Check if the implementation expects other missing properties. Review any comments or linked PRs for additional context.