CodeGenieApp/serverless-express

[Bug]: `ConfigureParams` type is out-of-date.

Open

#365 opened on Feb 5, 2021

View on GitHub
 (4 comments) (2 reactions) (0 assignees)JavaScript (674 forks)batch import
bughelp wanted

Repository metrics

Stars
 (4,977 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I was attempting to add a custom eventSource and was getting typehint failures as the eventSource isn't defined in the ConfigureParams type.

https://github.com/vendia/serverless-express/blob/mainline/src/configure.d.ts

Contributor guide

Research direction
Open the file src/configure.d.ts and check the ConfigureParams interface. Add the missing 'eventSource' property with appropriate type.
Tech stack
javascripttypescriptnodejsexpress
Domain
backendapicloud
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90