CodeEditApp/CodeEdit

馃悶 Sidebar tab panel state is not retained when returning to it from another tab

Open

#711 opened on Aug 3, 2022

View on GitHub
聽(3 comments)聽(0 reactions)聽(0 assignees)Swift聽(22,856 stars)聽(1,165 forks)batch import
UIbuggood first issue

Description

Description

Any sidebar tab panel needs to retain the state it was in before navigating away to a new sidebar tab panel. This applies to both the left navigator sidebar and the right inspector sidebar.

To Reproduce

  1. Make sure you are in the Project Navigator
  2. Expand a few folders
  3. Scroll down
  4. Open the Find Navigator
  5. Open the Project Navigator
  6. Notice folders previously expanded are now collapsed and scroll position is at the top.

Expected behavior

Folders that were previously expanded should remain expanded and scroll position should be as you left it upon returning to the sidebar tab panel.

Version information

CodeEdit: 1.0 Hash: bb373d99ddd7c91e31d6fd5a75d96db4fdbb9b3a MacOS: 12.5 (21G72) Xcode: 13.4.1 (13F100)

Contributor guide

Tech stack
swift
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Swift programmingBasic knowledge of SwiftUI state management
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue is about sidebar tab panels not retaining state. Look at the implementation of the sidebar tab views, possibly in files like `SidebarView.swift` or `NavigatorPanel.swift`. Investigate how state is managed when switching tabs. Consider using a view model with `@StateObject` or `@ObservableObject` to persist the state of each tab panel. Check if the tab panel views are being recreated each time the tab changes. A fix could involve storing the state in a parent view that remains alive, or using `onAppear`/`onDisappear` correctly.