ClickHouse/ClickHouse

Respect systemd clickhouse-server.service enable/disable status during update to new version

Open

#67,591 opened on Aug 1, 2024

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (8,400 forks)batch import
help wantednot plannedusability

Repository metrics

Stars
 (47,419 stars)
PR merge metrics
 (Avg merge 2d 2h) (1,000 merged PRs in 30d)

Description

Describe the issue Disabled systemd clickhouse-server.service became enabled after update to new version.

How to reproduce

  1. Install clickhouse-server
  2. Disable autostart sudo systemctl disable clickhouse-server.service
  3. Check systemd service status: 
    systemctl is-enabled clickhouse-server.service 
disabled
  4. Wait for new version or updated release ...
  5. Update clickhouse-server package 
    sudo apt update 
sudo apt install --upgrade clickhouse-server  # or just run  apt upgrade
  6. Check systemd service status: 
    systemctl is-enabled clickhouse-server.service 
enabled

Expected behavior Systemd service clickhouse-server.service should be disabled after update if it was disabled before.

Contributor guide

Research direction
Investigate how the package manager (e.g., apt) handles systemd service enable/disable during upgrades. Look at the post install scripts in the ClickHouse package to see if they are unconditionally enabling the service. Consider using 'deb systemd invoke' or similar mechanisms to preserve the enabled/disabled state.
Tech stack
shell
Domain
devopsinfrastructure
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Linuxsystemdpackage management
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50