CleverRaven/Cataclysm-DDA

Overmap coverage test needs to account for overmaps that spawn only in alternate Dimensions

Open

#84557 opened on Jan 8, 2026

View on GitHub
 (0 comments) (2 reactions) (0 assignees)C++ (9,264 stars) (3,991 forks)batch import
<Suggestion / Discussion>Code: TestsHelp WantedMap / Mapgen

Description

Is your feature request related to a problem? Please describe.

When adding overmaps that only spawn in alternate dimensions (the terrains: "standing_stones_highlands", "highlands" can serve as an example here) you must forcibly add their entries to the overmap_terrain_coverage_whitelist to allow the test to pass.

Effectively this means that we dont check for special spawning errors in alternate dimensions

Solution you would like.

The test is expanded to cover alternate dimensions.

Describe alternatives you have considered.

No response

Additional context

No response

Contributor guide

Tech stack
cpp
Domain
testing
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++overmap systemtest framework
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the overmap coverage test in the Cataclysm DDA codebase. Look for where overmap terrain whitelist is defined and how the current test fetches overmaps. The goal is to expand the test to also consider overmaps from alternate dimensions like 'standing stones highlands' and 'highlands'. Since this is a C++ project, relevant files are likely in src/ or data/. No linked PRs or maintainer comments are available.