CleverRaven/Cataclysm-DDA

Add general armor faults and it's fixes

Open

#80,881 opened on May 9, 2025

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (9,264 stars) (3,991 forks)batch import
(P5 - Long-term)<Suggestion / Discussion>Good First Issue[JSON]

Description

Is your feature request related to a problem? Please describe.

#80684 added faults that are applied when item is damaged. The pr itself was limited by adding faults only to vanilla melee weapons, but added "fault_type": "mechanical_damage", is, of course, not limited to items you are fighting with, meaning taking blows off your armor or driving over the items would apply the faults also Part of #64528

Solution you would like.

This issue is a call for people that may be interested in adding such to armor, guns and overall to items that may be damaged in any way that can be repaired by other means that our current repair system

Describe alternatives you have considered.

No response

Additional context

No response

Contributor guide

Tech stack
cpp
Domain
backenddata
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++ programmingunderstanding of game's damage system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Review PR #80684 to understand how mechanical damage faults were added to melee weapons. Examine the fault system and item definitions in the C++ source code (likely in data/json items or src). Identify how armor and gun items are structured and determine where to add similar fault entries. Consider extending the fault type to other repair methods or adding new faults specific to armor (e.g., dented, pierced). Finally, ensure compatibility with existing repair systems mentioned in #64528.