CleverRaven/Cataclysm-DDA

Creating more AIM tests, help wanted

Open

#80,000 opened on Mar 4, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (9,264 stars) (3,991 forks)batch import
<Suggestion / Discussion>Code: TestsHelp Wanted

Description

Is your feature request related to a problem? Please describe.

AIM is a pain to work on, with tons of special cases depending on type of source -, destpanel/charge items and a bunch of pre-filtering, so that any attempt to improve anything, it will break something. Automated testing would make the process a lot more stable, but since it is closely interwoven with UI and key-inputs it hasn't been done this far.

Solution you would like.

AIM has a lot of functions, so there will have to be a ton of tests, so I would like to recruit some help writing some tests, as soon as #79976 gets merged. An example test is in #79976. Only requirement is that you can compile the game.

  • Infrastructure to be able to test (#79976)
  • Navigation (selecting pane, swap pane etc.)

possible locations:

  • Inventory
  • Ground (all/9 specific locations)
  • Dragged
  • Vehicle (not dragged)
  • Container
  • Worn

Moving single/stack/set number of items:

  • anywhere to inv
  • anywhere to ground
  • anywhere to container
  • anywhere to vehicle
  • anywhere to dragged
  • anywhere to worn (also to wield)
  • items with charges

Other functionalities:

  • unload from Container view/container selected
  • Examine
  • move all

Describe alternatives you have considered.

No response

Additional context

Neat, it got the number 80000

Contributor guide

Tech stack
cpp
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
compile the gamebasic C++ knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine PR #79976 for the testing infrastructure and example test. Pick a specific checkbox (e.g., navigation or moving items) and implement tests following that pattern. Look for AIM related functions in src/aim*.cpp and add tests in the tests/ directory.