CleverRaven/Cataclysm-DDA

Using toggle fast travel doesn't record map memory at all

Open

#76,350 opened on Sep 11, 2024

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C++ (9,264 stars) (3,991 forks)batch import
(S2 - Confirmed)Code: Infrastructure / Style / Static AnalysisHelp WantedMap / Mapgen[C++]

Description

Describe the bug

When using the toggle fast travel option, it doesn't record map memory for your character. So if you decide to fast travel into an area that you have no map memory for, it will path there, but won't record any tiles.

Attach save file

TESTINGTWO-trimmed.tar.gz

Steps to reproduce

  1. Load save
  2. Fast travel to any nearby forest tile using 'toggle fast travel'
  3. Notice no map memory is updated

Expected behavior

Map memory should be recorded as if 'toggle fast travel' were off.

Screenshots

Just for clarification, I used the fast travel mechanic to get into this forest in the top-left spot, then directly east. I then disabled 'toggle fast travel' so that map view didn't stay open while traveling, and traveled south. As such, you have map memory when the option is disabled. image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.4651 (22H2)
  • Game Version: cdda-experimental-2024-09-10-0339 c73e4c6 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Portal Storms Ignore NPCs [personal_portal_storms], Slowdown Fungal Growth [no_fungal_growth] ]

Additional context

No response

Contributor guide

Tech stack
cpp
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++ knowledgeunderstanding of fast travel system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the fast travel mechanic in the game code, specifically how map memory is updated when using toggle fast travel. Look at the 'map memory' and 'fast travel' related functions. Compare behavior when toggle is on versus off. The issue likely lies in a conditional that skips memory recording when toggle is active.