CleverRaven/Cataclysm-DDA

Message order is not always correct

Open

#7,533 opened on May 4, 2014

View on GitHub
 (10 comments) (0 reactions) (0 assignees)C++ (9,264 stars) (3,991 forks)batch import
(P5 - Long-term)(S2 - Confirmed)<Bug>Help WantedInfo / User Interface

Description

Sometimes, the order the messages come in is wrong.

Real example after drinking 1 mutagen: “You gain a mutation called Herbivore! You gain a mutation called Leg Tentacles! You gain a mutation called Poison Resistant! Oops. You've must blacked out for a minute or so. You drink your mutagen. You wake up.” This is from the broad sidebar, so this means: normally, new messages appear at the bottom. But this log looks a bit messed up. According to the log, you get the mutations before you drinke the mutagen, and you drink it while you are passed out … lol

It seems to me the message order gets wrong always if multiple messages go into the log at the same time, I am not sure exatly.

Oh, and I know C:DDA has this bug for a very long time already. Still in master.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Contributor guide

Tech stack
cpp
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++ knowledgefamiliarity with game's message system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Examine the message logging code to understand how messages are ordered when multiple are added at the same time. Look for any sorting or timestamp issues in the source files responsible for the sidebar log. Check if there are known race conditions or delay mechanisms.