CleverRaven/Cataclysm-DDA

Tests: `guy != nullptr` randomly failing

Open

#73,352 opened on Apr 28, 2024

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (9,264 stars) (3,991 forks)batch import
<Bug>Code: TestsHelp Wanted[C++]

Description

Describe the bug

In all listed cases are also some armor display tests failing and this may be related. This specific random failure appears to be comparatively rare.

Unfortunately I lack the privileges in this repo to search through all workflow logs but I feel like I have seen this before. Can't prove it with additional links though.

Attach save file

Steps to reproduce

  1. Run tests.
  2. Win the rng lottery.
  3. Witness above failure.

Expected behavior

guy != nullptr

Screenshots

No response

Versions and configuration

n/a

Additional context

No response

Contributor guide

Tech stack
cpp
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C++ basicstest suite familiaritydebugging skillsgame logic understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the workflow logs linked in the issue to identify the exact assertion and stack trace. Search the test code for `guy != nullptr` to understand the context. Investigate the relationship between this test and the armor display tests that also fail randomly. Check if there is a race condition or missing initialization of the `guy` variable. Consider running the test multiple times locally to reproduce.