CleverRaven/Cataclysm-DDA

Tests: `guy != nullptr` randomly failing

Open

#73,352 opened on Apr 28, 2024

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)C++ (3,991 forks)batch import
<Bug>Code: TestsHelp Wanted[C++]

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the bug

In all listed cases are also some armor display tests failing and this may be related. This specific random failure appears to be comparatively rare.

Unfortunately I lack the privileges in this repo to search through all workflow logs but I feel like I have seen this before. Can't prove it with additional links though.

Attach save file

Steps to reproduce

  1. Run tests.
  2. Win the rng lottery.
  3. Witness above failure.

Expected behavior

guy != nullptr

Screenshots

No response

Versions and configuration

n/a

Additional context

No response

Contributor guide

Research direction
Investigate the failing test 'guy != nullptr' and trace the conditions leading to null pointer. Look for race conditions or missing assignments in the game logic.
Tech stack
ccpp
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40