CleverRaven/Cataclysm-DDA

Scent follows you through long-range teleports

Open

#72,625 opened on Mar 25, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (3,991 forks)batch import
(P4 - Low)<Bug>Code: DebugHelp Wanted[C++]

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Describe the bug

See title.

Attach save file

n/a

Steps to reproduce

  1. Generate some scent.

image

  1. Teleport somewhere else. In this case some forest a dozen overmap tiles away.

image

Expected behavior

Scent gets reset or something. Short-range teleports behave fine. Long-range ones do not. I first thought this was a problem of the game not redrawing the overlay but this is apparently not the case, as I saw when I teleported into solid earth for testing.

Screenshots

No response

Versions and configuration

  • OS: Linux
    • OS Version: LSB Version: n/a; Distributor ID: Arch; Description: Arch Linux; Release: rolling; Codename: n/a;
  • Game Version: 84b2f37 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Slowdown Fungal Growth [no_fungal_growth], Bionic Professions [package_bionic_professions] ]

Additional context

No response

Contributor guide

Research direction
Investigate how scent is updated on teleport and why it persists at old location after long range teleport. Check the map memory or scent map reset logic.
Tech stack
cpp
Domain
game dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70