CleverRaven/Cataclysm-DDA

Wetsuit and spring suit. Flag POCKETS

Open

#71,698 opened on Feb 11, 2024

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (3,991 forks)batch import
(S1 - Need confirmation)Good First IssueItems: Armor / Clothing[JSON]

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Describe the bug

I noticed that the wetsuit did not warm my hands. A spring suit keeps warm my hands . Both have pockets. But only the spring suit has the “POCKETS” flag.

Where is the error and is it there?

Attach save file

N/A

Steps to reproduce

N/A

Expected behavior

N/A

Screenshots

No response

Versions and configuration

N/A

Additional context

https://cdda-guide.nornagon.net/item/wetsuit https://cdda-guide.nornagon.net/item/wetsuit_spring

I'm confused by the description of the pockets: Back pocket

https://github.com/CleverRaven/Cataclysm-DDA/blob/eb9cacd70e0a2b6ac996e9cf2d316c6f3ad339fd/data/json/items/armor/swimming.json#L763

https://github.com/CleverRaven/Cataclysm-DDA/blob/eb9cacd70e0a2b6ac996e9cf2d316c6f3ad339fd/data/json/items/armor/swimming.json#L1514

Other

If a flag is needed, then pay attention to:

wetsuit -https://cdda-guide.nornagon.net/item/xl_wetsuit -https://cdda-guide.nornagon.net/item/xs_wetsuit

thick wetsuit -https://cdda-guide.nornagon.net/item/wetsuit_thick -https://cdda-guide.nornagon.net/item/xs_wetsuit_thick -https://cdda-guide.nornagon.net/item/xl_wetsuit_thick

Kevlar wetsuit https://cdda-guide.nornagon.net/item/h20survivor_jumpsuit https://cdda-guide.nornagon.net/item/xs_h20survivor_jumpsuit https://cdda-guide.nornagon.net/item/xl_h20survivor_jumpsuit

light Kevlar wetsuit oversuit https://cdda-guide.nornagon.net/item/h20survivor_jumpsuit_light https://cdda-guide.nornagon.net/item/xs_h20survivor_jumpsuit_light https://cdda-guide.nornagon.net/item/xl_h20survivor_jumpsuit_light

thick Kevlar wetsuit https://cdda-guide.nornagon.net/item/thick_h20survivor_jumpsuit https://cdda-guide.nornagon.net/item/xs_thick_h20survivor_jumpsuit https://cdda-guide.nornagon.net/item/xl_thick_h20survivor_jumpsuit

wetsuit technical shorts

Perhaps you should rename "spring suit" to "spring wetsuit"?

P.S. How did "spring suit" turn into "short wetsuit" when translated into Russian? This is a rhetorical question.

Contributor guide

Research direction
Compare the item definitions for wetsuit and spring suit in the linked JSON files. Specifically, look for the 'POCKETS' flag in the spring suit definition and ensure it is present in the wetsuit definition. Then check all other wetsuit variants (thick, Kevlar, etc.) for consistency and add the flag if missing. Consider also renaming 'spring suit' to 'spring wetsuit' for consistency.
Tech stack
None
Domain
game dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJSON
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80