CleverRaven/Cataclysm-DDA

Monster difficulty scores need auditing.

Open

#69,707 opened on Nov 24, 2023

View on GitHub
 (6 comments) (5 reactions) (0 assignees)C++ (3,991 forks)batch import
<Bugfix><Suggestion / Discussion>Good First IssueMonstersNPC / Factions

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Is your feature request related to a problem? Please describe.

During combat AI testing I have realized that the score we're getting for monsters is pretty wild and inaccurate. This is because there's the expectation that a JSON difficulty will be filled out to add some points to monsters that rely on special attacks for their difficulty.

Monsters that just use regular attacks seem to be scored OK

Solution you would like.

for now we should just go through and check out the reported difficulty of monsters and add some points in JSON if they're too low. Ferals, who rely on their wielded weapons for high damage, are a particularly egregious example.

Describe alternatives you have considered.

In the long run, some special attacks should be algorithmically added to the difficulty. We'll always need JSON adjustment for special attacks that don't do damage.

Additional context

This is something that should have a ci test I think. Any creature with multiple special attacks should require a Difficulty entry in the JSON, and we should perhaps test a few low difficulty creatures against a similarly scored NPC to make sure they actually are low difficulty.

Contributor guide