CleverRaven/Cataclysm-DDA

Charge removal side effects 3: unmigrated item spawns

Open

#67,326 opened on Jul 31, 2023

View on GitHub
 (0 comments) (2 reactions) (0 assignees)C++ (3,991 forks)batch import
(S2 - Confirmed)Help WantedSpawn[JSON]

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Describe the bug

There are countless places that allow inline definitions of itemgroups or other shorthand definitions that were not caught by the automated script, so all of these are now broken and only spawn single items instead of the defined charges or default charges of the item.

Where to find these cases:

  1. Inside regular itemgroups
    • "distribution" or "collection" members inside the "items" or "entries" array
    • simple itype entries inside the "items" array
  2. Professions
    • lots of simple itype entries, although probably not many that spawn with comestibles
  3. Mapgen (and vehicles?)
    • this one is the most tricky, because there are many different ways to define spawns and I definitely don't know all of them
  4. Recipe byproducts
    • haven't actually confirmed that one, but it's probably an issue?
  5. Probably other places I forgot
    • comments appreciated

All affected items and their previous default charges can be found here: https://gist.github.com/mqrause/dc234737bfd5c4309aa4dc496d17bd53#file-removed_charges-txt

Attach save file

n/a

Steps to reproduce

n/a

Expected behavior

n/a

Screenshots

No response

Versions and configuration

6088293934801590f503ff9d5d961e708af564ff

Additional context

No response

Contributor guide