CleverRaven/Cataclysm-DDA

Crossbow firing sound bug, CC-Sounds

Open

#67,031 opened on Jul 19, 2023

View on GitHub
 (1 comment) (1 reaction) (0 assignees)C++ (3,991 forks)batch import
(S2 - Confirmed)Help WantedSDL: Tiles / SoundSound Events[C++]

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Describe the bug

Installing a bow dampening kit on a compound crossbow changes the firing sound to that of a rifle.

Attach save file

Wake Forest.zip

Steps to reproduce

  1. Fire crossbow.
  2. Install bow dampening kit.
  3. Reload and fire crossbow again.
  4. Note the difference in sound.

Expected behavior

Expecting the mod to either not change the sound made, or change it to a less gun-like one.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.3208 (22H2)
  • Game Version: 29cf306 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Portal Storms Ignore NPCs [personal_portal_storms], Slowdown Fungal Growth [no_fungal_growth], No Rail Stations [No_Rail_Stations], Stats Through Kills [stats_through_kills] ]

Additional context

Using the CC-Sounds Soundpack.

Contributor guide

Research direction
Investigate the sound change logic when a bow dampening kit is installed on a crossbow. Trace the firing sound selection code to find why the rifle sound is played instead of a modified crossbow sound.
Tech stack
None
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35